----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34575/#review85484 -----------------------------------------------------------
Ship it! Minor comment below; otherwise looks good. exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/filter/TestLargeInClause.java <https://reviews.apache.org/r/34575/#comment137062> The 'values' in the name is misleading since large IN lists are list of values; you test is specific to expressions, so you could call this testExprsInInList. - Aman Sinha On May 22, 2015, 5:41 p.m., Sean Hsuan-Yi Chu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34575/ > ----------------------------------------------------------- > > (Updated May 22, 2015, 5:41 p.m.) > > > Review request for drill, Aman Sinha and Jinfeng Ni. > > > Bugs: DRILL-3019 > https://issues.apache.org/jira/browse/DRILL-3019 > > > Repository: drill-git > > > Description > ------- > > In JsonReader, update atLeastOneWrite to true if writeListDataIfTyped and > writeMapDataIfTyped write a value > > > Diffs > ----- > > > exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/fn/JsonReader.java > 095d8c6 > > exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/filter/TestLargeInClause.java > 281a946 > > Diff: https://reviews.apache.org/r/34575/diff/ > > > Testing > ------- > > Unit, TPCH done > > waiting for functional... > > > Thanks, > > Sean Hsuan-Yi Chu > >
