----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35365/#review87660 -----------------------------------------------------------
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/UnsupportedOperatorsVisitor.java <https://reviews.apache.org/r/35365/#comment140067> we should check for ROWS and RANGE also.. exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/UnsupportedOperatorsVisitor.java <https://reviews.apache.org/r/35365/#comment140066> Can we make this message more descriptive ? default frame is generic. - Aman Sinha On June 11, 2015, 11:46 p.m., Sean Hsuan-Yi Chu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35365/ > ----------------------------------------------------------- > > (Updated June 11, 2015, 11:46 p.m.) > > > Review request for drill, Aman Sinha and Jinfeng Ni. > > > Bugs: DRILL-3182, DRILL-3188 and DRILL-3195 > https://issues.apache.org/jira/browse/DRILL-3182 > https://issues.apache.org/jira/browse/DRILL-3188 > https://issues.apache.org/jira/browse/DRILL-3195 > > > Repository: drill-git > > > Description > ------- > > Window function with DISTINCT qualifier is disabled; Disable unsupported > window frames; Window functions NTILE, LAG, LEAD, FIRST_VALUE, LAST_VALUE are > disabled > > > Diffs > ----- > > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/UnsupportedOperatorsVisitor.java > b92de3b > exec/java-exec/src/test/java/org/apache/drill/exec/TestWindowFunctions.java > fc75d73 > > Diff: https://reviews.apache.org/r/35365/diff/ > > > Testing > ------- > > All the required tests > > > Thanks, > > Sean Hsuan-Yi Chu > >
