> On June 12, 2015, 12:24 a.m., Aman Sinha wrote: > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/UnsupportedOperatorsVisitor.java, > > line 155 > > <https://reviews.apache.org/r/35365/diff/2/?file=983482#file983482line155> > > > > we should check for ROWS and RANGE also..
Have modified the if condition > On June 12, 2015, 12:24 a.m., Aman Sinha wrote: > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/UnsupportedOperatorsVisitor.java, > > line 171 > > <https://reviews.apache.org/r/35365/diff/2/?file=983482#file983482line171> > > > > Can we make this message more descriptive ? default frame is generic. Added the info in: "When OVER-CLAUSE contains an ORDER BY, " + "only window frames RANGE UNBOUNDED PRECEDING " + "and RANGE BETWEEN UNBOUNDED PRECEDING AND CURRENT ROW are supported \n" + "When OVER-CLAUSE does not contain an ORDER BY, " + "only window frames RANGE BETWEEN UNBOUNDED PRECEDING AND UNBOUNDED FOLLOWING " + "and ROWS BETWEEN UNBOUNDED PRECEDING AND UNBOUNDED FOLLOWING \n" + "See Apache Drill JIRA: DRILL-3188"); - Sean Hsuan-Yi ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35365/#review87660 ----------------------------------------------------------- On June 15, 2015, 5:38 p.m., Sean Hsuan-Yi Chu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35365/ > ----------------------------------------------------------- > > (Updated June 15, 2015, 5:38 p.m.) > > > Review request for drill, Aman Sinha and Jinfeng Ni. > > > Bugs: DRILL-3182, DRILL-3188 and DRILL-3195 > https://issues.apache.org/jira/browse/DRILL-3182 > https://issues.apache.org/jira/browse/DRILL-3188 > https://issues.apache.org/jira/browse/DRILL-3195 > > > Repository: drill-git > > > Description > ------- > > Window function with DISTINCT qualifier is disabled; Disable unsupported > window frames; Window functions NTILE, LAG, LEAD, FIRST_VALUE, LAST_VALUE are > disabled > > > Diffs > ----- > > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/UnsupportedOperatorsVisitor.java > f3c54cc > exec/java-exec/src/test/java/org/apache/drill/exec/TestWindowFunctions.java > fc75d73 > > Diff: https://reviews.apache.org/r/35365/diff/ > > > Testing > ------- > > All the required tests > > > Thanks, > > Sean Hsuan-Yi Chu > >
