----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35484/ -----------------------------------------------------------
(Updated June 23, 2015, 1:20 a.m.) Review request for drill, Mehant Baid and Venki Korukanti. Changes ------- Added unit tests to cover various reallocation scenarios. Fixed unit tests to avoid leaks via closing out resources. VVs throw OversizedAllocationException if allocation demand is more than the allowed max. Ensure that flatten handles OversizedAllocationException to split the batch and resume the execution. Repository: drill-git Description ------- DRILL-2851: set an upper-bound on # of bytes to re-allocate to prevent overflows Vectors - set an upper bound on # of bytes to allocate - TestValueVector.java - Add unit tests Diffs (updated) ----- exec/java-exec/src/main/codegen/includes/vv_imports.ftl 92c80072cfcde4deb0bbb34bc3b688707541f2f6 exec/java-exec/src/main/codegen/templates/FixedValueVectors.java 7103a17108693d47839212c418d11d13fbb8f6f4 exec/java-exec/src/main/codegen/templates/NullableValueVectors.java 7f835424b68a9d68b0a6c60749677a83ac486590 exec/java-exec/src/main/codegen/templates/VariableLengthVectors.java 50ae770f24aff1e8eed1dfa800878ce92308c644 exec/java-exec/src/main/java/org/apache/drill/exec/exception/OversizedAllocationException.java PRE-CREATION exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/flatten/FlattenRecordBatch.java 999140498ab303d3f5ecf20695755bdfe943cb46 exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/flatten/FlattenTemplate.java de67b62248a68c1f483808c4b575e0afa7854aca exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/flatten/Flattener.java 92cf79d37da89864ab7702830fe078479773a73e exec/java-exec/src/main/java/org/apache/drill/exec/vector/BaseDataValueVector.java 0e38f3cad3792e936ff918ae970f4b40e478d516 exec/java-exec/src/main/java/org/apache/drill/exec/vector/BaseValueVector.java 8129668b6ff5dc674e30dca6947bd93c87fb4d3d exec/java-exec/src/main/java/org/apache/drill/exec/vector/BitVector.java 10bdf0752632c7577b9a6eb445c7101ec1a24730 exec/java-exec/src/test/java/org/apache/drill/exec/record/vector/TestValueVector.java 037c8c6d3da94acf5c2ca300ce617338cacb0fb0 Diff: https://reviews.apache.org/r/35484/diff/ Testing ------- all Thanks, Hanifi Gunes
