----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35484/#review89076 -----------------------------------------------------------
Ship it! exec/java-exec/src/main/codegen/templates/NullableValueVectors.java (line 134) <https://reviews.apache.org/r/35484/#comment141677> If the allocation of the bit vector fails will this cause issues calling zeroVector on an unallocated vector? I think there is a risk that we will have a null buffer that the old code would defend against, the zeroVector() method calls a method on the data buffer directly. We need to add a return false after the clear in the finally block. exec/java-exec/src/main/codegen/templates/NullableValueVectors.java (line 216) <https://reviews.apache.org/r/35484/#comment141678> Same as above - Jason Altekruse On June 23, 2015, 10:59 p.m., Hanifi Gunes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35484/ > ----------------------------------------------------------- > > (Updated June 23, 2015, 10:59 p.m.) > > > Review request for drill, Jason Altekruse and Mehant Baid. > > > Repository: drill-git > > > Description > ------- > > DRILL-2851: set an upper-bound on # of bytes to re-allocate to prevent > overflows > Vectors > - set an upper bound on # of bytes to allocate > - > TestValueVector.java > - Add unit tests > > > Diffs > ----- > > exec/java-exec/src/main/codegen/includes/vv_imports.ftl > 92c80072cfcde4deb0bbb34bc3b688707541f2f6 > exec/java-exec/src/main/codegen/templates/FixedValueVectors.java > 7103a17108693d47839212c418d11d13fbb8f6f4 > exec/java-exec/src/main/codegen/templates/NullableValueVectors.java > 7f835424b68a9d68b0a6c60749677a83ac486590 > exec/java-exec/src/main/codegen/templates/VariableLengthVectors.java > 50ae770f24aff1e8eed1dfa800878ce92308c644 > > exec/java-exec/src/main/java/org/apache/drill/exec/exception/OversizedAllocationException.java > PRE-CREATION > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/flatten/FlattenRecordBatch.java > 999140498ab303d3f5ecf20695755bdfe943cb46 > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/flatten/FlattenTemplate.java > de67b62248a68c1f483808c4b575e0afa7854aca > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/flatten/Flattener.java > 92cf79d37da89864ab7702830fe078479773a73e > > exec/java-exec/src/main/java/org/apache/drill/exec/vector/BaseDataValueVector.java > 0e38f3cad3792e936ff918ae970f4b40e478d516 > > exec/java-exec/src/main/java/org/apache/drill/exec/vector/BaseValueVector.java > 8129668b6ff5dc674e30dca6947bd93c87fb4d3d > exec/java-exec/src/main/java/org/apache/drill/exec/vector/BitVector.java > 10bdf0752632c7577b9a6eb445c7101ec1a24730 > > exec/java-exec/src/test/java/org/apache/drill/exec/record/vector/TestValueVector.java > 037c8c6d3da94acf5c2ca300ce617338cacb0fb0 > > Diff: https://reviews.apache.org/r/35484/diff/ > > > Testing > ------- > > all > > > Thanks, > > Hanifi Gunes > >
