Hanifi went through a complete review on a patch with github and has checked in his change.
To see how github reflected the discussion on JIRA you can look here: https://issues.apache.org/jira/browse/DRILL-3441 It looks like my section of the process relating to posting patches to JIRA as well as creating/updating your pull request might not be needed. The content of the intermediate work while it is in review does not seem to end up on JIRA or the mailing list with the automatic integration. Questions: Do we need to have the patches as they change throughout a review on the apache infrastructure? If not, do we want to have final patch on the JIRA? Or should users interested in backporting a bug fix just go right to the repo to find the changeset to apply? On Tue, Jul 7, 2015 at 11:17 PM, Ted Dunning <[email protected]> wrote: > > If the code patches get chexked in on the apache git, they propagate to gh > and close the PR request there. > > No fancy plugins needed for that. Mentioning the jira gets a link to the > PR and the content of the PR gets mirrored to the mailing list as it > happens as well. > > Sent from my iPhone > > > On Jul 7, 2015, at 17:51, Jason Altekruse <[email protected]> > wrote: > > > > I'm going to do a little more digging, because it is not clear to me if > > the actual content of the patches makes it back to the JIRA with this > > automatic integration. It would be nice to remove the extra step of > > generating and uploading patch files, but we want to make sure we have > the > > code changes stored on apache infra somehow. >
