Hello All, As you might have noticed, we have started opening up pull requests for new patches and going through the review cycle over on github.
I wanted to bring up one small issue that Sudheesh noticed with my review of one of his patches. He had posted his change-set in two parts (the primary benefit of the PRs over reviewboard) I was looking at each of the commits individually and making in-line comments. When I looked back at the PR I saw my comments listed and assigned the JIRA back to him address my comments. Unfortunately, it looks like comments on the individual commits are aggregated into the pull request, but these comments have not been reflected back on JIRA. It looks like we should be making the comments on the combination of all of the changes available in a PR with the "files changed" link, rather than commenting on the individual commits. We can still use the separation of the commits to look at individual work units, but it would be best to have the discussion reflected on JIRA. Example of comments that appear on the PR but were not copied to JIRA: https://github.com/apache/drill/pull/90 https://issues.apache.org/jira/browse/DRILL-2304 I will be opening an infra ticket if there is not already one to request these comments also be reflected if possible. On Wed, Jul 8, 2015 at 10:53 PM, Ted Dunning <[email protected]> wrote: > On Wed, Jul 8, 2015 at 6:19 PM, Parth Chandra <[email protected]> wrote: > > > > If not, do we want to have final patch on the JIRA? Or should users > > > interested in backporting a bug fix just go right to the repo to find > the > > > changeset to apply? > > > > > > > > The patch is not really needed in the JIRA I think. It would be nice if > > the commit id itself is in the JIRA when the issue is closed. Going to > the > > pull request to get the commit id is a few clicks too many. > > > Concur with this. > > Git will have all the history needed. If the JIRA has the discussion, this > is good. >
