Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/93#discussion_r34634834
--- Diff:
common/src/main/java/org/apache/drill/common/config/DrillConfig.java ---
@@ -44,26 +46,33 @@
import com.google.common.collect.ImmutableList;
import com.typesafe.config.Config;
import com.typesafe.config.ConfigFactory;
+import com.typesafe.config.ConfigRenderOptions;
public final class DrillConfig extends NestedConfig{
-// private static final org.slf4j.Logger logger =
org.slf4j.LoggerFactory.getLogger(DrillConfig.class);
+ private static final Logger logger = getLogger(DrillConfig.class);
--- End diff --
Why not *just* uncomment (the pattern we follow everywhere)? Why add
imports?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
