Github user dsbos commented on the pull request:
https://github.com/apache/drill/pull/93#issuecomment-121513460
> ... clutter Lilith ... 3) Every other log statement in your patch should
be TRACE level. ...
Commit 872309a... reverts to one log call and log entry per list, but
retains the improved readability by putting each listed item on a separate line.
> ... 1) Overrides in DrillConfig (step 3 and 4 in DrillConfig#create)
could be at INFO level. ...
Since the set of per-module configuration files is affected by user action
(installing plug-ins), step 2's logging should probably be at the same level.
And then, since that's reporting every configuration file except the
defaults file, maybe the defaults file should also be listed at the same level.
Comments? (INFO for all those config files?)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
