Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/120#discussion_r39114713
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/vector/BitVector.java ---
@@ -211,8 +220,11 @@ public TransferPair makeTransferPair(ValueVector to) {
public void transferTo(BitVector target) {
target.clear();
+ if (target.data != null) {
+ target.data.release();
--- End diff --
release(1) ?
Also, do you intend to change from retain() to retain(1) across the source
codes? Seems some places are still using retain(). Do a quick search will find
couple of places, including BitVector.load(), VariableLengthVectors.java:load()
etc.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
