Github user cwestin commented on a diff in the pull request:
https://github.com/apache/drill/pull/120#discussion_r39197169
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/vector/BitVector.java ---
@@ -211,8 +220,11 @@ public TransferPair makeTransferPair(ValueVector to) {
public void transferTo(BitVector target) {
target.clear();
+ if (target.data != null) {
+ target.data.release();
--- End diff --
Originally I did change all the release()s and retain()s to (1) in all
files. But Jacques made me undo them in a few files he reviewed in another
patch, and I haven't searched to see if there are new additions since I made
the original changes. I think it's worth saving the function call for some
low-level things (such as value vectors). What would you prefer?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
