Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/159#discussion_r40877406
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/options/FallbackOptionManager.java
---
@@ -102,6 +125,29 @@ public void setOption(OptionValue value) {
}
@Override
+ public void deleteOption(final String name, final OptionType type) {
+ try {
+ SystemOptionManager.getValidator(name); // ensure the option exists
+ } catch (final IllegalArgumentException e) {
+ throw UserException.validationError(e)
+ .build(logger);
--- End diff --
Initially, I made that change in the ```getValidator``` function, but it
seemed like UserException was one level too deep (if that makes sense). This
way the calling function can do whatever it wants with the exception e.g. wrap
it in a UserException for the user, or ignore it in case of a unit test.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
