Github user jacques-n commented on a diff in the pull request:
https://github.com/apache/drill/pull/159#discussion_r40880950
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/options/FallbackOptionManager.java
---
@@ -102,6 +125,29 @@ public void setOption(OptionValue value) {
}
@Override
+ public void deleteOption(final String name, final OptionType type) {
+ try {
+ SystemOptionManager.getValidator(name); // ensure the option exists
+ } catch (final IllegalArgumentException e) {
+ throw UserException.validationError(e)
+ .build(logger);
--- End diff --
My main issue here is that we have an unfriendly message. One of the things
that we should be doing is creating a user friendly message at the point of
user exception creation. If you think it was too deep one level deeper, then
you should make a friendly user message at this level. Trusting that the system
level exception message is meaningful to the user should be avoided.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
