Github user julienledem commented on a diff in the pull request:
https://github.com/apache/drill/pull/246#discussion_r44204847
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/WorkspaceSchemaFactory.java
---
@@ -313,19 +734,29 @@ public String getTypeName() {
return FileSystemConfig.NAME;
}
+ private DrillTable isReadable(FormatMatcher m, FileSelection
fileSelection) throws IOException {
+ return m.isReadable(fs, fileSelection, plugin, storageEngineName,
schemaConfig.getUserName());
+ }
+
@Override
- public DrillTable create(String key) {
+ public DrillTable create(TableInstance key) {
try {
- FileSelection fileSelection = FileSelection.create(fs,
config.getLocation(), key);
+ FileSelection fileSelection = FileSelection.create(fs,
config.getLocation(), key.sig.name);
if (fileSelection == null) {
return null;
}
-
+ if (key.sig.params.size() > 0) {
+ FormatPluginConfig fconfig = optionExtractor.eval(key);
+// TextFormatPlugin.TextFormatConfig fconfig = new
TextFormatPlugin.TextFormatConfig();
+// fconfig.extensions = Arrays.asList();
+// fconfig.fieldDelimiter = ((String)key.params.get(0)).charAt(0);
--- End diff --
todo: cleanup
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
