Github user jacques-n commented on a diff in the pull request:

    https://github.com/apache/drill/pull/246#discussion_r44821281
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/WorkspaceSchemaFactory.java
 ---
    @@ -148,12 +175,427 @@ private Path getViewPath(String name) {
         return DotDrillType.VIEW.getPath(config.getLocation(), name);
       }
     
    -  public WorkspaceSchema createSchema(List<String> parentSchemaPath, 
SchemaConfig schemaConfig) throws  IOException {
    +  public WorkspaceSchema createSchema(List<String> parentSchemaPath, 
SchemaConfig schemaConfig) throws IOException {
         return new WorkspaceSchema(parentSchemaPath, schemaName, schemaConfig);
       }
     
    -  public class WorkspaceSchema extends AbstractSchema implements 
ExpandingConcurrentMap.MapValueFactory<String, DrillTable> {
    -    private final ExpandingConcurrentMap<String, DrillTable> tables = new 
ExpandingConcurrentMap<>(this);
    +  /**
    +   * Describes the options for a format plugin
    +   * extracted from the FormatPluginConfig subclass
    +   */
    +  static final class OptionsDescriptor {
    --- End diff --
    
    Can you pull this out into a separate file?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to