Github user parthchandra commented on the pull request:
https://github.com/apache/drill/pull/250#issuecomment-155632914
In general the patch looks fine. I'm not sure I follow the reason for the
drill-logical package.
My one concern was similar to Hakim's that this would affect the allocator
changes quite a bit (and I think the allocator changes add more value). Can we
split the changes? @adeneche can you comment on what changes would make it
easier for you to merge?
BTW, master has moved and there is a merge conflict (easily resolved).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
