Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/340#discussion_r52186222
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/config/WindowPOP.java
---
@@ -33,26 +35,29 @@
private final NamedExpression[] withins;
private final NamedExpression[] aggregations;
private final Order.Ordering[] orderings;
- private final long start;
- private final long end;
+ private final boolean rows;
--- End diff --
The 'rows' variable typically could be misinterpreted to mean number of
rows (here you are using it as ROWS vs RANGE)..maybe rename it ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
