Github user adeneche commented on a diff in the pull request:
https://github.com/apache/drill/pull/340#discussion_r53351144
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/window/TestWindowFrame.java
---
@@ -106,6 +106,60 @@ public void testMultipleFramers() throws Exception {
);
}
+ @Test
+ public void testUnboundedFollowing() throws Exception {
+ testBuilder()
+ .sqlQuery(getFile("window/q3.sql"), TEST_RES_PATH)
+ .ordered()
+ .sqlBaselineQuery(getFile("window/q4.sql"), TEST_RES_PATH)
+ .build()
+ .run();
+ }
+
+ @Test
+ public void testAggregateRowsUnboundedAndCurrentRow() throws Exception {
+ final String table = "dfs_test.`"+TEST_RES_PATH+"/window/b4.p4`";
+ testBuilder()
+ .sqlQuery(getFile("window/aggregate_rows_unbounded_current.sql"),
table)
+ .ordered()
+
.sqlBaselineQuery(getFile("window/aggregate_rows_unbounded_current_baseline.sql"),
table)
+ .build()
+ .run();
+ }
+
+ @Test
+ public void testLastValueRowsUnboundedAndCurrentRow() throws Exception {
+ final String table = "dfs_test.`"+TEST_RES_PATH+"/window/b4.p4`";
+ testBuilder()
+ .sqlQuery(getFile("window/last_value_rows_unbounded_current.sql"),
table)
+ .unOrdered()
+
.sqlBaselineQuery(getFile("window/last_value_rows_unbounded_current_baseline.sql"),
table)
+ .build()
+ .run();
+ }
+
+ @Test
+ public void testAggregateRangeCurrentAndCurrent() throws Exception {
--- End diff --
the added tests use the window/b4.p4 dataset that contains 4 partitions.
The second partition has a frame that has 3 rows at the end of the 1st batch
and 2 rows at the beginning of the second batch.
Is this enough, or should I generate another dataset with a frame that
spans over more than 2 batches ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
