Github user arina-ielchiieva commented on the pull request:
https://github.com/apache/drill/pull/482#issuecomment-215135279
@sudheeshkatkam,
I have updated pull request according your comments:
1. renamed bit -> drillbit where applicable
2. updated warning message as suggested
3. added static and final where applicable
4. changed cluster version default to empty string
5. added check after drillbit is registered if cluster version is set to
default and if yes update it to current drillbit version
Test case 1:
1. register first drillbit with version 1.7.0-SNAPSHOT
2. check first drillbit Web UI, cluster version is 1.7.0-SNAPSHOT
3. register second drillbit with version 1.8.0-SNAPSHOT
4. check first drillbit Web UI, cluster version is 1.7.0-SNAPSHOT, warning
is generated
5. check second drillbit Web UI, cluster version is 1.7.0-SNAPSHOT, warning
is generated
6. update cluster version to 1.8.0-SNAPSHOT
7. check first drillbit Web UI, cluster version is 1.8.0-SNAPSHOT, warning
is generated
8. check second drillbit Web UI, cluster version is 1.8.0-SNAPSHOT, warning
is generated
9. add drillbit with previous version (before changes)
10. check first drillbit Web UI, cluster version is 1.8.0-SNAPSHOT, warning
is generated, new drillbit version is marked as underfined
Test case 2:
1. register first drillbit with version 1.7.0-SNAPSHOT
2. check first drillbit Web UI, cluster version is 1.7.0-SNAPSHOT
3. register second drillbit with version 1.7.0-SNAPSHOT
4. check first drillbit Web UI, cluster version is 1.7.0-SNAPSHOT, warning
is absent
5. check second drillbit Web UI, cluster version is 1.7.0-SNAPSHOT, warning
is absent
Also I have added appropriate screenshots to Jira.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
