Github user parthchandra commented on a diff in the pull request:
https://github.com/apache/drill/pull/518#discussion_r67390934
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/store/json/TestJsonRecordReader.java
---
@@ -116,6 +117,7 @@ public void testMixedNumberTypes() throws Exception {
.jsonBaselineFile("jsoninput/mixed_number_types.json")
.build().run();
} catch (Exception ex) {
+ ex.printStackTrace();
--- End diff --
Not a good idea to print stack trace in unit tests. The output of our unit
tests is already too verbose.
Use junit.fail with the message from the exception instead?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
