Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/518#discussion_r67426795
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/store/json/TestJsonRecordReader.java
---
@@ -179,4 +180,43 @@ public void testNestedFilter() throws Exception {
.sqlBaselineQuery(baselineQuery)
.go();
}
+
+ @Test // See DRILL-4653
+public void testSkippingInvalidJSONRecords() throws Exception {
+ try
+ {
+ String set = "alter session set `" +
ExecConstants.JSON_READER_SKIP_INVALID_RECORDS_FLAG+ "` = true";
--- End diff --
these should be indented inside the try block with 2 spaces. It is best
to set the indent level in your IDE (I can help with Eclipse if you are using
it; if you are using IntelliJ I can find out from other developers using
IntelliJ).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
