Github user sudheeshkatkam commented on a diff in the pull request:

    https://github.com/apache/drill/pull/520#discussion_r69999975
  
    --- Diff: 
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillDatabaseMetaDataImpl.java
 ---
    @@ -1273,5 +1295,11 @@ public boolean generatedKeyAlwaysReturned() throws 
SQLException {
         return super.generatedKeyAlwaysReturned();
       }
     
    +  private ResultSet executeSql(String sql) throws SQLException {
    --- End diff --
    
    -1
    
    I don't think executing a query is the right way to figure out server 
properties. Maybe a set of server properties should be returned as part of 
establishing a connection (identifier quote string being one such property).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to