Github user gparai commented on a diff in the pull request:
https://github.com/apache/drill/pull/534#discussion_r71012854
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/options/SystemOptionManager.java
---
@@ -251,7 +254,12 @@ public void setOption(final OptionValue value) {
final String name = value.name.toLowerCase();
final OptionValidator validator = getValidator(name);
- validator.validate(value); // validate the option
+ /* If the validator depends on other options */
+ if (validator instanceof DependentTypeValidators) {
+ ((DependentTypeValidators)validator).validate(value, this); //
validate the option
--- End diff --
The validation is also done in the FallbackOptionManager. A testcase is
present which checks the validation when changing the option in the session.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
