Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/534#discussion_r71013627
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/options/TypeValidators.java
---
@@ -27,6 +27,21 @@
import static com.google.common.base.Preconditions.checkArgument;
public class TypeValidators {
+
+ /** Interface implemented by option validators which depend on other
options
+ * in order to perform validation. e.g. MIN/MAX option validators might
be
+ * dependent if MIN should always be less than MAX.
+ *
+ */
+ public interface DependentTypeValidators
+ {
+ /* Interface method requires providing an OptionManager which can
+ * be used to read option values of dependencies. As an example look at
+ * MinRangeDoubleValidator/MaxRangeDoubleValidator
+ */
+ public void validate(OptionValue v, BaseOptionManager manager);
--- End diff --
Would replacing `validate(OptionValue)` with `validate(OptionValue,
OptionManager)` in the `OptionValidator` interface work?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
