Jinfeng, Not initially, but I figured out how to correct the inconsistent protocols yesterday (manually ran protoc on *.proto, after seeing other *.proto include Types.proto, and an uncaught and un-logged class load exception under debugger after Drill just hung running a SQL select). I'm now unit testing new VarDecimal logic, with all the code I'm expecting to run, actually running.
For me, this was not an obvious place to look for those instructions. I found I needed to modify the protocol Types.proto by looking through source code, to location where all types are initially defined. It might help other newbies to put the instructions right there in the same folder protocol/src/main/protobuf with the *.proto files. Are there any other hugely useful readme's I should be reading? Like on how to successfully use debugger on Drill (which is still flaky sometimes, latest IntelliJ IDEA)? Dave Oshinsky -----Original Message----- From: Jinfeng Ni [mailto:[email protected]] Sent: Wednesday, August 10, 2016 8:59 PM To: dev Subject: Re: question on failed unit test (in protobuf) Did you follow the steps specified in this readme.txt [1]? [1] https://github.com/apache/drill/blob/master/protocol/readme.txt On Tue, Aug 9, 2016 at 3:59 PM, Dave Oshinsky <[email protected]> wrote: > I have a drill 1.7 node (Windows 7, Java 8) in which I've made numerous > experimental changes to try adding a new kind of vector, VarDecimal. I found > that I needed to modify Types.proto to add "VARDECIMAL = 43;", and I ran > protoc.exe to generate a new TypeProtos.java. Do I need to change something > else to avoid this strange Protobuf-related failure? > Thanks, > Dave Oshinsky > > Running org.apache.drill.exec.DrillSeparatePlanningTest > SLF4J: Failed toString() invocation on an object of type > [org.apache.drill.exec.proto.UserProtos$RunQuery] > java.lang.ExceptionInInitializerError > at > org.apache.drill.exec.proto.UserProtos.<clinit>(UserProtos.java:7304) > at > org.apache.drill.exec.proto.UserProtos$RunQuery.internalGetFieldAccessorTable(UserProtos.java:3704) > at > com.google.protobuf.GeneratedMessage.getAllFieldsMutable(GeneratedMessage.java:105) > at > com.google.protobuf.GeneratedMessage.getAllFields(GeneratedMessage.java:153) > at com.google.protobuf.TextFormat$Printer.print(TextFormat.java:272) > at > com.google.protobuf.TextFormat$Printer.access$400(TextFormat.java:248) > at com.google.protobuf.TextFormat.print(TextFormat.java:71) > at com.google.protobuf.TextFormat.printToString(TextFormat.java:118) > at > com.google.protobuf.AbstractMessage.toString(AbstractMessage.java:106) > at > org.slf4j.helpers.MessageFormatter.safeObjectAppend(MessageFormatter.java:305) > at > org.slf4j.helpers.MessageFormatter.deeplyAppendParameter(MessageFormatter.java:277) > at > org.slf4j.helpers.MessageFormatter.arrayFormat(MessageFormatter.java:231) > at > ch.qos.logback.classic.spi.LoggingEvent.<init>(LoggingEvent.java:115) > at > ch.qos.logback.classic.Logger.buildLoggingEventAndAppend(Logger.java:439) > at ch.qos.logback.classic.Logger.filterAndLog_1(Logger.java:413) > at ch.qos.logback.classic.Logger.debug(Logger.java:506) > at > org.apache.drill.exec.client.DrillClient$ListHoldingResultsListener.<init>(DrillClient.java:428) > at > org.apache.drill.exec.client.DrillClient.runQuery(DrillClient.java:327) > at org.apache.drill.QueryTestUtil.createClient(QueryTestUtil.java:69) > at org.apache.drill.BaseTestQuery.openClient(BaseTestQuery.java:196) > at > org.apache.drill.BaseTestQuery.setupDefaultTestCluster(BaseTestQuery.java:122) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47) > at > org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) > at > org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44) > at > mockit.integration.junit4.internal.JUnit4TestRunnerDecorator.invokeExplosively(JUnit4TestRunnerDecorator.java:44) > at > mockit.integration.junit4.internal.MockFrameworkMethod.invokeExplosively(MockFrameworkMethod.java:29) > at sun.reflect.GeneratedMethodAccessor15.invoke(Unknown Source) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > mockit.internal.util.MethodReflection.invokeWithCheckedThrows(MethodReflection.java:95) > at > mockit.internal.annotations.MockMethodBridge.callMock(MockMethodBridge.java:76) > at > mockit.internal.annotations.MockMethodBridge.invoke(MockMethodBridge.java:41) > at > org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java) > at > org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:24) > at > org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27) > at org.junit.runners.ParentRunner.run(ParentRunner.java:309) > at > org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:264) > at > org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:153) > at > org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:124) > at > org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:200) > at > org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:153) > at > org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:1 > 03) Caused by: java.lang.IllegalArgumentException: Invalid embedded > descriptor for "SchemaDef.proto". > at > com.google.protobuf.Descriptors$FileDescriptor.internalBuildGeneratedFileFrom(Descriptors.java:301) > at > org.apache.drill.exec.proto.SchemaDefProtos.<clinit>(SchemaDefProtos.java:142) > ... 46 more > Caused by: com.google.protobuf.Descriptors$DescriptorValidationException: > SchemaDef.proto: Dependencies passed to FileDescriptor.buildFrom() don't > match those listed in the FileDescriptorProto. > at > com.google.protobuf.Descriptors$FileDescriptor.buildFrom(Descriptors.java:246) > at > com.google.protobuf.Descriptors$FileDescriptor.internalBuildGeneratedFileFrom(Descriptors.java:299) > ... 47 more > j
