Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/574#discussion_r77691775
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/DrillFunctionRegistry.java
---
@@ -39,15 +46,20 @@
import com.google.common.collect.ArrayListMultimap;
import org.apache.drill.exec.planner.sql.DrillSqlOperatorWithoutInference;
+import org.apache.drill.exec.proto.UserBitShared.Func;
/**
* Registry of Drill functions.
*/
public class DrillFunctionRegistry {
+
+ public static final String BUILT_IN = "built-in";
+
private static final org.slf4j.Logger logger =
org.slf4j.LoggerFactory.getLogger(DrillFunctionRegistry.class);
- // key: function name (lowercase) value: list of functions with that name
- private final ArrayListMultimap<String, DrillFuncHolder>
registeredFunctions = ArrayListMultimap.create();
+ // function registry holder
--- End diff --
Did cursory review. Needs thorough review from someone familiar with this
code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
