Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/574#discussion_r77695664
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/DrillFunctionRegistry.java
---
@@ -218,4 +302,141 @@ private void
registerOperatorsWithoutInference(DrillOperatorTable operatorTable)
}
}
}
+
+ /**
+ * Function registry holder. Stores function implementations by jar
name, function name.
+ */
+ private class GenericRegistryHolder<T, U> {
--- End diff --
Similarly, U is a parameter class. GenericRegistryHolder is private, so the
only uses of this class are in this file. The only use in this file specifies
DrillFuncHolder as the value of U. So, code can be simper by just using that
class name instead of a parameter.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
