[GitHub] drill pull request #595: DRILL-4203: Parquet File. Date is stored wrongly

[parthchandra]

Github user parthchandra commented on a diff in the pull request:

    https://github.com/apache/drill/pull/595#discussion_r81240013
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetReaderUtility.java
 ---
    @@ -18,16 +18,62 @@
     package org.apache.drill.exec.store.parquet;
     
     import org.apache.drill.common.exceptions.UserException;
    +import org.apache.drill.common.expression.PathSegment;
    +import org.apache.drill.common.expression.SchemaPath;
     import org.apache.drill.exec.planner.physical.PlannerSettings;
     import org.apache.drill.exec.server.options.OptionManager;
    +import org.apache.drill.exec.store.AbstractRecordReader;
    +import org.apache.drill.exec.store.ParquetOutputRecordWriter;
     import org.apache.drill.exec.work.ExecErrorConstants;
    +import org.apache.parquet.SemanticVersion;
    +import org.apache.parquet.VersionParser;
    +import org.apache.parquet.column.ColumnDescriptor;
    +import org.apache.parquet.column.statistics.Statistics;
    +import org.apache.parquet.format.ConvertedType;
    +import org.apache.parquet.format.FileMetaData;
    +import org.apache.parquet.format.SchemaElement;
    +import org.apache.parquet.format.converter.ParquetMetadataConverter;
    +import org.apache.parquet.hadoop.ParquetFileWriter;
    +import org.apache.parquet.hadoop.metadata.ColumnChunkMetaData;
    +import org.apache.parquet.hadoop.metadata.ColumnPath;
    +import org.apache.parquet.hadoop.metadata.ParquetMetadata;
    +import org.apache.parquet.schema.OriginalType;
    +import org.joda.time.Chronology;
    +import org.joda.time.DateTimeConstants;
    +
    +import java.util.Arrays;
    +import java.util.HashMap;
    +import java.util.List;
    +import java.util.Map;
     
     /*
      * Utility class where we can capture common logic between the two parquet 
readers
      */
     public class ParquetReaderUtility {
       private static final org.slf4j.Logger logger = 
org.slf4j.LoggerFactory.getLogger(ParquetReaderUtility.class);
     
    +  // Note the negation symbol in the beginning
    +  public static final double CORRECT_CORRUPT_DATE_SHIFT = 
-ParquetOutputRecordWriter.JULIAN_DAY_EPOC - 0.5;
    --- End diff --
    
    Is the the number by which you must correct the incorrect values? If so, 
please add a comment. This had me very confused for a while.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---