Github user jaltekruse commented on a diff in the pull request:

    https://github.com/apache/drill/pull/595#discussion_r81396800
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/Metadata.java 
---
    @@ -918,18 +916,22 @@ public void setMax(Object max) {
         @JsonProperty public ConcurrentHashMap<ColumnTypeMetadata_v2.Key, 
ColumnTypeMetadata_v2> columnTypeInfo;
         @JsonProperty List<ParquetFileMetadata_v2> files;
         @JsonProperty List<String> directories;
    -    @JsonProperty String drillVersion;
    --- End diff --
    
    I had intentionally added the drill version here assuming that it would be 
good information to have around if a similar issue ever comes up the the 
future, as well as provide all of the info we need to have an explicit flag 
that the dates have become correct. For this to work completely, this commit 
should be the last commit right before a release (it could be a point release). 
Any particular reason that we would want to not write it into the file?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to