Github user parthchandra commented on a diff in the pull request:
    --- Diff: 
    @@ -754,15 +764,45 @@ public void testImpalaParquetVarBinary_DictChange() 
throws Exception {
    +  @Test
    +  public void testImpalaParquetBinaryTimeStamp_DictChange() throws 
Exception {
    +    try {
    +      test("alter session set %s = true", 
    +      compareParquetReadersColumnar("field_impala_ts", 
    --- End diff --
    This is not a good enough test. Both the baseline and test case queries 
will use the getDateTimeValueFromBinary method and if there is a bug in that 
method, the test will still pass as both will produce the same incorrect value. 
Better to compare with the actual baseline value in the file.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

Reply via email to