Github user bitblender commented on a diff in the pull request:

    https://github.com/apache/drill/pull/600#discussion_r83761501
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetReaderUtility.java
 ---
    @@ -45,4 +53,34 @@ public static int getIntFromLEBytes(byte[] input, int 
start) {
         }
         return out;
       }
    +
    +  /**
    +   * Utilities for converting from parquet INT96 binary (impala, hive 
timestamp)
    +   * to date time value. This utilizes the Joda library.
    +   */
    +  public static class NanoTimeUtils {
    +
    +    public static final long NANOS_PER_DAY = TimeUnit.DAYS.toNanos(1);
    +    public static final long NANOS_PER_HOUR = TimeUnit.HOURS.toNanos(1);
    +    public static final long NANOS_PER_MINUTE = 
TimeUnit.MINUTES.toNanos(1);
    +    public static final long NANOS_PER_SECOND = 
TimeUnit.SECONDS.toNanos(1);
    +    public static final long NANOS_PER_MILLISECOND =  
TimeUnit.MILLISECONDS.toNanos(1);
    +
    +  /**
    +   * @param binaryTimeStampValue
    +   *          hive, impala timestamp values with nanoseconds precision
    +   *          are stored in parquet Binary as INT96
    +   *
    +   * @return  the number of milliseconds since January 1, 1970, 00:00:00 
GMT
    +   *          represented by @param binaryTimeStampValue .
    +   */
    +    public static long getDateTimeValueFromBinary(Binary 
binaryTimeStampValue) {
    +      NanoTime nt = NanoTime.fromBinary(binaryTimeStampValue);
    +      int julianDay = nt.getJulianDay();
    +      long nanosOfDay = nt.getTimeOfDayNanos();
    +      return DateTimeUtils.fromJulianDay(julianDay-0.5d) + 
nanosOfDay/NANOS_PER_MILLISECOND;
    --- End diff --
    
    Sorry for the late reply. For some reason, I did not see these comments 
till now. 
    About 1) Yes, you are correct. I just want the comments in 
ConvertFromImpalaTimestamp to be removed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to