Venki, could you please take a look, since you are most familiar with that
piece of code? Or anyone else wants to take a look?
The issue can be reproduced with a simple unit test. In
TestJdbcPluginWithDerbyIT, add this test. and then run “mvn install” in the
storage-jdbc sub-project.
@Test // DRILL-4984
public void limit0() throws Exception {
testNoResult("SELECT * FROM derby.DRILL_DERBY_TEST.PERSON LIMIT 0");
}
In the ticket, Hogler suggested “adding a check for null in
FindHardDistributionScans.java @line 55 before calling getDrillTable()”. But
that check may not be sufficient (I could be wrong) because the check does not
imply if “contains” should be set to true/false. The call to unwrap() returns a
different type of table (not DrillTable or DrillTranslatableTable), and that
may need to be investigated.
Thank you,
Sudheesh
> On Nov 17, 2016, at 10:09 PM, Jacques Nadeau <[email protected]> wrote:
>
> It might make sense for someone to look at this jira before rolling another
> release: DRILL-4984
>
> The stacktrace looks like it might be an issue with the new hard
> parallelization algorithm which could potentially influence all sources. It
> might not have shown up in traditional regression tests if those always
> have source/drillbit affinity (just a random guess).
>
> --
> Jacques Nadeau
> CTO and Co-Founder, Dremio
>
> On Thu, Nov 17, 2016 at 10:50 AM, Sudheesh Katkam <[email protected]
> <mailto:[email protected]>>
> wrote:
>
>> Hi all,
>>
>> I had not noticed that Gautam mentioned about a potential bug. That is a
>> -1 from me on the proposed candidate; the bug is a regression in behavior.
>> I did not push the release artifacts until now, and the announcement is not
>> out.
>>
>> The issue is that the query profile is not displayed past the point of
>> failure (trying to show a changed string option). So I will propose another
>> candidate once this issue is fixed [1, 2].
>>
>> In the mean time, please test the candidate for other regressions.
>>
>> Thank you,
>> Sudheesh
>>
>> [1] https://issues.apache.org/jira/browse/DRILL-5047 <
>> https://issues.apache.org/jira/browse/DRILL-5047
>> <https://issues.apache.org/jira/browse/DRILL-5047>>
>> [2] https://github.com/apache/drill/pull/655
>> <https://github.com/apache/drill/pull/655> <https://github.com/apache/
>> <https://github.com/apache/>
>> drill/pull/655>
>>
>>> On Nov 16, 2016, at 7:15 PM, Sudheesh Katkam <[email protected]>
>> wrote:
>>>
>>> The proposal passes!
>>>
>>> Final tally:
>>>
>>> 3 binding +1s
>>> + Sudheesh
>>> + Aman
>>> + Parth
>>>
>>> 12 non-binding +1s
>>> + Khurram
>>> + Dechang
>>> + Rahul
>>> + Chunhui
>>> + Karthikeyan
>>> + Robert
>>> + Paul
>>> + Krystal
>>> + Sorabh
>>> + Abhishek
>>> + Kunal
>>> + Gautam
>>>
>>> No 0s or -1s
>>>
>>> I'll push the release artifacts, and send an announcement once
>> propagated. Thanks to everyone involved!
>>>
>>> Thank you,
>>> Sudheesh
>>>
>>>> On Nov 16, 2016, at 6:23 PM, Gautam Parai <[email protected]> wrote:
>>>>
>>>> +1 (non-binding)
>>>>
>>>> Built from source on Linux VM and Mac.
>>>> Ran unit tests.
>>>> Ran new tests derived from bugs (Drill-4986/Drill-4771/Drill-
>>>> 4792/Drill-4927)
>>>> Ran some random queries
>>>>
>>>> Found a potential bug (NON-blocker) in Drill-4792.
>>>>
>>>> LGTM
>>>>
>>>> On Wed, Nov 16, 2016 at 5:52 PM, Kunal Khatua <[email protected]>
>> wrote:
>>>>
>>>>> +1 (non-binding)
>>>>>
>>>>> Built from the GitHub repo and deployed on a 10-node setup.
>>>>> Ran a bunch of queries and verified the profiles as well.
>>>>>
>>>>> LGTM.
>>>>>
>>>>>
>>>>> On Wed 16-Nov-2016 3:41:03 PM, Abhishek Girish <[email protected]>
>> wrote:
>>>>> +1 (non-binding)
>>>>>
>>>>> Built from source. Ran Functional and Advanced tests from [1]. Sanity
>>>>> tested Sqlline and Web UI. Looks good.
>>>>>
>>>>>
>>>>> [1] https://github.com/mapr/drill-test-framework.git
>>>>>
>>>>>
>>>>> On Wed, Nov 16, 2016 at 3:37 PM, Sorabh Hamirwasia
>>>>>> wrote:
>>>>>
>>>>>> +1 (non-binding)
>>>>>> Built from source and successfully ran unit tests.
>>>>>> Ran both in embedded and distributed mode.
>>>>>> Verified DRILL-4972 / DRILL-4964
>>>>>> Ran some basic query on sys tables and sample data.
>>>>>>
>>>>>> Looks good.
>>>>>>
>>>>>>
>>>>>> On Wed, Nov 16, 2016 at 2:49 PM, Krystal Nguyen
>>>>>> wrote:
>>>>>>
>>>>>>> +1 (non-binding)
>>>>>>> Built from source. Tested the WebUI including authentication. Tested
>>>>>>> sqlline.
>>>>>>>
>>>>>>> On Wed, Nov 16, 2016 at 1:59 PM, Paul Rogers
>>>>>> wrote:
>>>>>>>
>>>>>>>> +1 (non-binding)
>>>>>>>> Built from source
>>>>>>>> Ran script unit tests to verify config settings, etc.
>>>>>>>>
>>>>>>>> Looks good.
>>>>>>>>
>>>>>>>> - Paul
>>>>>>>>
>>>>>>>>> On Nov 16, 2016, at 1:46 PM, Robert Hou wrote:
>>>>>>>>>
>>>>>>>>> +1 (non-binding)
>>>>>>>>>
>>>>>>>>> Built from source.
>>>>>>>>> Tested parquet filter pushdown.
>>>>>>>>>
>>>>>>>>> On Wed, Nov 16, 2016 at 1:22 PM, Karthikeyan Manivannan
>>>>>>>>> [email protected]> wrote:
>>>>>>>>>
>>>>>>>>>> +1
>>>>>>>>>>
>>>>>>>>>> Built from source.
>>>>>>>>>> Ran tests in embedded mode to verify the fix for DRILL-4974.
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> On Wed, Nov 16, 2016 at 1:11 PM, Parth Chandra
>>>>>> [email protected]
>>>>>>>>
>>>>>>>>>> wrote:
>>>>>>>>>>
>>>>>>>>>>> +1 (binding)
>>>>>>>>>>>
>>>>>>>>>>> Checked the source and binary signatures.
>>>>>>>>>>> Built from source.
>>>>>>>>>>> Ran a few hundred queries against Parquet files.
>>>>>>>>>>> Built C++ client. Ran a bunch of queries.
>>>>>>>>>>>
>>>>>>>>>>> All looks good.
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> On Wed, Nov 16, 2016 at 12:02 PM, Chunhui Shi
>>>>>>>> wrote:
>>>>>>>>>>>
>>>>>>>>>>>> +1 (non-binding)
>>>>>>>>>>>> 1, clone branch from https://github.com/sudheeshkatkam/drill/
>>>>>>>>>>>>
>>>>>>> switch
>>>>>>>>>> to
>>>>>>>>>>>> drill-1.9.0 branch
>>>>>>>>>>>> 2, built drill from source with unit tests. All passes
>>>>>>>>>>>> 3, check git-properties
>>>>>>>>>>>> 4, run embedded mode and verify some parquet and native reader
>>>>>>> default
>>>>>>>>>>>> values in sys.options.
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>> On Tue, Nov 15, 2016 at 2:20 PM, rahul challapalli
>>>>>>>>>>>> [email protected]> wrote:
>>>>>>>>>>>>
>>>>>>>>>>>>> +1 (Non-Binding)
>>>>>>>>>>>>>
>>>>>>>>>>>>> 1. Downloaded and built drill from source
>>>>>>>>>>>>> 2. Ran functional tests [1], and Advanced tests [2].
>>>>>>>>>>>>> 3. Ran some simple queries on INFORMATION_SCHEMA and sys tables
>>>>>>>>>>>>> 4. Tried out a few legacy udf's developed prior to Drill-1.0
>>>>>>>>>>>>> 5. Sanity tested cancellation of running queries
>>>>>>>>>>>>>
>>>>>>>>>>>>> [1]
>>>>>>>>>>>>> https://github.com/mapr/drill-test-framework/tree/master/
>>>>>>>>>>>>> framework/resources/Functional
>>>>>>>>>>>>> [2]
>>>>>>>>>>>>> https://github.com/mapr/drill-test-framework/tree/master/
>>>>>>>>>>>>> framework/resources/Advanced
>>>>>>>>>>>>>
>>>>>>>>>>>>> On Tue, Nov 15, 2016 at 11:39 AM, Sudheesh Katkam
>>>>>>>>>>> [email protected]>
>>>>>>>>>>>>> wrote:
>>>>>>>>>>>>>
>>>>>>>>>>>>>> Hi all,
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> The vote ends tomorrow at 6:30 PM PT; please vote!
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> As of now, there are only two binding votes.
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Thank you,
>>>>>>>>>>>>>> Sudheesh
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> On Nov 14, 2016, at 7:51 AM, Dechang Gu
>>>>>>>>>> wrote:
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> +1
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> - build from source
>>>>>>>>>>>>>>> - deployed on a cluster
>>>>>>>>>>>>>>> - run TPCH and TPCDS SF100
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> LGTM.
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> -Dechang
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> On Sun, Nov 13, 2016 at 6:13 PM, Aman Sinha
>>>>>>>>>> [email protected]>
>>>>>>>>>>>>>> wrote:
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> +1 (binding)
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> - Downloaded the binaries on my mac, verified README,
>>>>>>>>>>> git.properties
>>>>>>>>>>>>> and
>>>>>>>>>>>>>>>> KEYS file GPG key
>>>>>>>>>>>>>>>> - Ran several queries, including CTAS against TPC-H data.
>>>>>>>>>> Checked
>>>>>>>>>>>>>> Explain
>>>>>>>>>>>>>>>> plans and results for a few queries.
>>>>>>>>>>>>>>>> - Checked Web UI for query profiles.
>>>>>>>>>>>>>>>> - Downloaded source on my Linux VM, did a build and ran unit
>>>>>>>>>> tests
>>>>>>>>>>>>>>>> successfully.
>>>>>>>>>>>>>>>> - Checked Maven artifacts on repositories.apache.org
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> -Aman
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> On Sat, Nov 12, 2016 at 12:27 PM, Khurram Faraaz
>>>>>>>>>>>>> [email protected]>
>>>>>>>>>>>>>>>> wrote:
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> Built from source without unit tests.
>>>>>>>>>>>>>>>>> deployed binaries on a cluster.
>>>>>>>>>>>>>>>>> executed some basic SQL queries (like aggregation, joins,
>>>>>> range
>>>>>>>>>>>>> search
>>>>>>>>>>>>>>>> etc)
>>>>>>>>>>>>>>>>> from sqlline.
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> looks good to me.
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> On Sat, Nov 12, 2016 at 7:48 AM, Sudheesh Katkam
>>>>>>>>>>>>> [email protected]>
>>>>>>>>>>>>>>>>> wrote:
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> Hi all,
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> I would like to propose the second release candidate (RC1)
>>>>>> of
>>>>>>>>>>>> Apache
>>>>>>>>>>>>>>>>> Drill,
>>>>>>>>>>>>>>>>>> version 1.9.0. Thanks to everyone who contributed to this
>>>>>>>>>>> release!
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> + Compared to RC0, this release candidate does not contain
>>>>>>>>>>>>> DRILL-4373,
>>>>>>>>>>>>>>>>> due
>>>>>>>>>>>>>>>>>> to a regression (DRILL-5034).
>>>>>>>>>>>>>>>>>> + The release candidate covers a total of 73 resolved
>>>>> JIRAs
>>>>>>>>>> [1].
>>>>>>>>>>>>>>>>>> + The tarball artifacts are hosted at [2], and the maven
>>>>>>>>>>> artifacts
>>>>>>>>>>>>> are
>>>>>>>>>>>>>>>>>> hosted at [3].
>>>>>>>>>>>>>>>>>> + This release candidate is based on commit
>>>>>>>>>>>>>>>>>> db3085498c2dc481f734733535c877dfffb9afea located at [4].
>>>>>>>>>>>>>>>>>> + The artifacts are signed with the key at [5].
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> The vote ends at 6:30 PM PT, November 16th, 2016.
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> Here's my vote: +1
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> Thank you,
>>>>>>>>>>>>>>>>>> Sudheesh
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> [1]
>>>>>>>>>>>>>>>>>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?
>>>>>>>>>>>>>>>>>> projectId=12313820&version=12337861
>>>>>>>>>>>>>>>>>> [2] http://people.apache.org/~
>>>>>> sudheesh/drill/releases/1.9.0/
>>>>>>>>>>> rc1/
>>>>>>>>>>>>>>>>>> [3] https://repository.apache.org/content/repositories/
>>>>>>>>>>>>>>>>>> orgapachedrill-1038/
>>>>>>>>>>>>>>>>>> [4] https://github.com/sudheeshkatkam/drill/commits/
>>>>>>>>>> drill-1.9.0
>>>>>>>>>>>>>>>>>> [5] https://people.apache.org/keys/committer/sudheesh.asc
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>> --
>>>>>> Thanks,
>>>>>> Sorabh
