Github user Ben-Zvi commented on a diff in the pull request:
https://github.com/apache/drill/pull/716#discussion_r94696407
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/compile/CodeCompiler.java ---
@@ -153,4 +242,17 @@ public GeneratedClassEntry(final Class<?> clazz) {
public void flushCache() {
cache.invalidateAll();
}
+
+ /**
+ * Upon close, report the effectiveness of the code cache to the log.
+ */
+
+ public void close() {
+ logger.info("Class gen count: " + classGenCount);
--- End diff --
A very minor suggestion: Put all three loggings on a single log line (for
sake of making the log more compact; indeed this is not the main offender ....)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
