Github user Ben-Zvi commented on a diff in the pull request:

    https://github.com/apache/drill/pull/716#discussion_r94709919
  
    --- Diff: exec/java-exec/src/main/resources/drill-module.conf ---
    @@ -167,24 +167,61 @@ drill.exec: {
         debug: true,
         janino_maxsize: 262144,
         cache_max_size: 1000,
    -    // Enable to write generated source to disk. See ClassBuilder
    -    save_source: false,
         // Where to save the generated source. See ClassBuilder
         code_dir: "/tmp/drill/codegen"
    +    // Disable code cache. Only for testing.
    +    disable_cache: false,
    +    // Use plain Java compilation where available
    +    prefer_plain_java: false
       },
       sort: {
         purge.threshold : 1000,
         external: {
    -      batch.size : 4000,
    +      // Drill uses the managed External Sort Batch by default.
    --- End diff --
    
    The following two changes are not related to DRILL-5116.  Should they be 
moved to another PR ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to