Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/578#discussion_r99256832
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/control/ControllerImpl.java
---
@@ -39,36 +39,33 @@
static final org.slf4j.Logger logger =
org.slf4j.LoggerFactory.getLogger(ControllerImpl.class);
private volatile ControlServer server;
- private final ControlMessageHandler handler;
private final BootStrapContext context;
private final ConnectionManagerRegistry connectionRegistry;
- private final boolean allowPortHunting;
private final CustomHandlerRegistry handlerRegistry;
+ private final BitConnectionConfigImpl config;
- public ControllerImpl(BootStrapContext context, ControlMessageHandler
handler, BufferAllocator allocator,
- boolean allowPortHunting) {
- super();
- this.handler = handler;
+ public ControllerImpl(BootStrapContext context, BufferAllocator
allocator, ControlMessageHandler handler) {
this.context = context;
- this.connectionRegistry = new ConnectionManagerRegistry(allocator,
handler, context);
- this.allowPortHunting = allowPortHunting;
+ config = new BitConnectionConfigImpl(allocator, context, handler);
+ this.connectionRegistry = new ConnectionManagerRegistry(config);
this.handlerRegistry = handler.getHandlerRegistry();
}
@Override
- public DrillbitEndpoint start(DrillbitEndpoint partialEndpoint) throws
DrillbitStartupException {
- server = new ControlServer(handler, context, connectionRegistry);
+ public DrillbitEndpoint start(DrillbitEndpoint partialEndpoint, final
boolean allowPortHunting)
+ throws DrillbitStartupException {
--- End diff --
nothing inside the constructor throws **`DrillbitStartupException`**
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
