Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/578#discussion_r99257539
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/data/DataConnectionCreator.java
---
@@ -37,40 +37,28 @@
static final org.slf4j.Logger logger =
org.slf4j.LoggerFactory.getLogger(DataConnectionCreator.class);
private volatile DataServer server;
- private final BootStrapContext context;
- private final WorkEventBus workBus;
- private final WorkerBee bee;
- private final boolean allowPortHunting;
- private ConcurrentMap<DrillbitEndpoint, DataConnectionManager>
connectionManager = Maps.newConcurrentMap();
- private final BufferAllocator dataAllocator;
+ private final ConcurrentMap<DrillbitEndpoint, DataConnectionManager>
connectionManager = Maps.newConcurrentMap();
- public DataConnectionCreator(
- BootStrapContext context,
- BufferAllocator allocator,
- WorkEventBus workBus,
- WorkerBee bee,
- boolean allowPortHunting) {
- super();
- this.context = context;
- this.workBus = workBus;
- this.bee = bee;
- this.allowPortHunting = allowPortHunting;
- this.dataAllocator = allocator;
+ private final BitConnectionConfigImpl config;
+
+ public DataConnectionCreator(BootStrapContext context, BufferAllocator
allocator, WorkEventBus workBus,
+ WorkerBee bee) {
+ config = new BitConnectionConfigImpl(allocator, context, new
DataServerRequestHandler(workBus, bee));
}
- public DrillbitEndpoint start(DrillbitEndpoint partialEndpoint) throws
DrillbitStartupException {
- server = new DataServer(context, dataAllocator, workBus, bee);
+ public DrillbitEndpoint start(DrillbitEndpoint partialEndpoint, boolean
allowPortHunting)
+ throws DrillbitStartupException {
--- End diff --
Same as ControlServer
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
