Github user ppadma commented on a diff in the pull request:

    https://github.com/apache/drill/pull/827#discussion_r115485196
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/store/provider/LocalPersistentStoreProvider.java
 ---
    @@ -27,28 +27,30 @@
     import org.apache.drill.exec.store.sys.PersistentStoreConfig;
     import org.apache.drill.exec.store.sys.PersistentStoreRegistry;
     import org.apache.drill.exec.store.sys.store.LocalPersistentStore;
    -import org.apache.drill.exec.testing.store.NoWriteLocalStore;
    +import org.apache.drill.exec.store.sys.store.EphemeralPersistentStore;
     import org.apache.hadoop.fs.Path;
     
     /**
      * A really simple provider that stores data in the local file system, one 
value per file.
      */
     public class LocalPersistentStoreProvider extends 
BasePersistentStoreProvider {
    -//  private static final Logger logger = 
LoggerFactory.getLogger(LocalPersistentStoreProvider.class);
    +  private static final org.slf4j.Logger logger = 
org.slf4j.LoggerFactory.getLogger(LocalPersistentStoreProvider.class);
     
       private final Path path;
       private final DrillFileSystem fs;
       // This flag is used in testing. Ideally, tests should use a specific 
PersistentStoreProvider that knows
       // how to handle this flag.
    -  private final boolean enableWrite;
    +  private final boolean useEphemeral;
    +  private int maxCapacity;
    --- End diff --
    
    can we name this maxEphemeralCapacity or maxEphemeralProfiles ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to