Github user kkhatua commented on a diff in the pull request:

    https://github.com/apache/drill/pull/827#discussion_r115548554
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/store/EphemeralPersistentStore.java
 ---
    @@ -93,6 +107,14 @@ public void put(final String key, final V value, final 
DataChangeVersion dataCha
             throw new VersionMismatchException("Version mismatch detected", 
dataChangeVersion.getVersion());
           }
           store.put(key, value);
    +      currentSize.incrementAndGet();
    +
    +      if (currentSize.get() > maxCapacity) {
    +        //Pop Out Oldest
    +        ((ConcurrentSkipListMap<String, V>) store).pollLastEntry();
    --- End diff --
    
    The natural ordering of the profiles actually has the 'smallest' key being 
the latest. Hence, we pop out the oldest entry by getting the 'largest'/last 
entry


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to