Github user arina-ielchiieva commented on a diff in the pull request:

    https://github.com/apache/drill/pull/877#discussion_r127322605
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/Metadata.java 
---
    @@ -1377,7 +1386,7 @@ public void serialize(ColumnMetadata_v2 value, 
JsonGenerator jgen, SerializerPro
        *
        * Difference between v3 and v2 : min/max, type_length, precision, 
scale, repetitionLevel, definitionLevel
        */
    -  @JsonTypeName("v3") public static class ParquetTableMetadata_v3 extends 
ParquetTableMetadataBase {
    +  @JsonTypeName("v3_1") public static class ParquetTableMetadata_v3 
extends ParquetTableMetadataBase {
    --- End diff --
    
    Can be replaced with `Version` enum (ex: `Version.V1.getName()`), the same 
in `ParquetTableMetadataBase` class?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to