Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/877#discussion_r127366251
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/store/parquet/TestParquetMetadataCache.java
---
@@ -446,10 +447,25 @@ public void testMetadataCacheAbsolutePaths() throws
Exception {
}
}
+ @Test
--- End diff --
Tests for the version checks? A bit tricky because you have to create a
file and "predict" the next version.
For this, you need a way to get the current version from your `Version`
enum. Then do some simple logic to try:
* Add .1 to version number: 3.1 becomes 3.2.
* Move to next whole version number: 3.1 becomes 4.
Then, create a file with that version and check how this version of the
code handles a future version of the file.
To be thorough, also create a file that contains a field that Jackson
cannot deserialize. Be sure we properly handle a "hard" version incompatibility
as discussed earlier.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
