Github user arina-ielchiieva commented on a diff in the pull request:

    https://github.com/apache/drill/pull/877#discussion_r132413275
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetGroupScan.java
 ---
    @@ -268,11 +276,15 @@ private FileSelection expandIfNecessary(FileSelection 
selection) throws IOExcept
         // use the cacheFileRoot if provided (e.g after partition pruning)
         Path metaFilePath = new Path(cacheFileRoot != null ? cacheFileRoot : 
selectionRoot, Metadata.METADATA_FILENAME);
         if (!fs.exists(metaFilePath)) { // no metadata cache
    +      MetadataContext metaContext = selection.getMetaContext();
    --- End diff --
    
    It seems you set metadata context, when there can be the cases when it is 
still null? Also can you please explain why there are so many checks in the 
code if meta context is null, can we make sure it always exists?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to