Github user arina-ielchiieva commented on a diff in the pull request:

    https://github.com/apache/drill/pull/877#discussion_r132414700
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/Metadata.java 
---
    @@ -519,17 +564,16 @@ private void writeFile(ParquetTableMetadataDirs 
parquetTableMetadataDirs, Path p
       /**
        * Read the parquet metadata from a file
        *
    -   * @param path
    -   * @return
    -   * @throws IOException
    +   * @param path to metadata file
    +   * @param dirsOnly true for {@link 
Metadata#METADATA_DIRECTORIES_FILENAME}
    +   *                 or false for {@link Metadata#METADATA_FILENAME} files 
reading
    +   * @param metaContext current metadata context
    +   * @throws IOException if metadata file can't be read or updated
        */
    -  private void readBlockMeta(String path,
    -      boolean dirsOnly,
    -      MetadataContext metaContext) throws IOException {
    +  private void readBlockMeta(Path path, boolean dirsOnly, MetadataContext 
metaContext) {
         Stopwatch timer = Stopwatch.createStarted();
    -    Path p = new Path(path);
    -    Path parentDir = Path.getPathWithoutSchemeAndAuthority(p.getParent()); 
// parent directory of the metadata file
    -    String parentDirString = parentDir.toUri().toString(); // string 
representation for parent directory of the metadata file
    +    Path parentDir = 
Path.getPathWithoutSchemeAndAuthority(path.getParent()); // parent directory of 
the metadata file
    +    String parentDirString = parentDir.toUri().getPath(); // string 
representation for parent directory of the metadata file
    --- End diff --
    
    `parentDirPath`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to