Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/973#discussion_r143770360
--- Diff:
contrib/format-maprdb/src/main/java/org/apache/drill/exec/store/mapr/db/binary/MapRDBBinaryTable.java
---
@@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.drill.exec.store.mapr.db.binary;
+
+import java.io.IOException;
+
+import org.apache.drill.common.exceptions.UserException;
+import org.apache.drill.exec.store.dfs.FileSystemPlugin;
+import org.apache.drill.exec.store.dfs.FormatSelection;
+import org.apache.drill.exec.store.hbase.AbstractHBaseDrillTable;
+import org.apache.drill.exec.store.mapr.TableFormatPlugin;
+import org.apache.drill.exec.store.mapr.db.MapRDBFormatPlugin;
+import org.apache.hadoop.hbase.TableName;
+import org.apache.hadoop.hbase.client.Admin;
+
+public class MapRDBBinaryTable extends AbstractHBaseDrillTable {
+ private static final org.slf4j.Logger logger =
org.slf4j.LoggerFactory.getLogger(MapRDBBinaryTable.class);
+
+ public MapRDBBinaryTable(String storageEngineName, FileSystemPlugin
storagePlugin, TableFormatPlugin formatPlugin,
+ FormatSelection selection) {
+ super(storageEngineName, storagePlugin, selection);
+ String tableName = selection.getSelection().getFiles().get(0);
--- End diff --
1. What if we factor out `tableName` logic into MapRDBFormatPlugin class
into `getTableName` method (don't forget to add `@JsonIgnore`) since it's
common here and in `MapRDBFormatPlugin` class.
2. Maybe we can factor out common logic for getting `tableDesc ` as well
and place it, for example, into `AbstractHBaseDrillTable` class in `protected
void setTableDesc(Connection connection, String tableName)`?
---
