Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/973#discussion_r144158971
--- Diff:
contrib/storage-hbase/src/main/java/org/apache/drill/exec/store/hbase/HBaseUtils.java
---
@@ -139,4 +142,26 @@ public static Filter orFilterAtIndex(Filter
currentFilter, int index, Filter new
return Bytes.compareTo(left, right) < 0 ? left : right;
}
+
+ /**
+ * Verify the presence of a column family in the schema path of the
hbase table or whether the schema path is
+ * the row key column.
+ *
+ * @param columns List of the selected columns
+ * @param hTableDesc HTableDescriptor of HBase/MapR-DB_binary table
(consists the details about that table)
+ * @throws DrillRuntimeException if column family does not exist, or is
not row_key column.
+ */
+ public static void verifyColumns(List<SchemaPath> columns,
HTableDescriptor hTableDesc) {
--- End diff --
DRILL-5546 introduced expanding wildcard in the `verifyColumns()` method
with renaming to `verifyColumnsAndConvertStar()`. But this PR keeps the
original `verifyColumns()` method and the same in DRILL-5830 (the star isn't
expanded here). Just the method have started to be common to HBase and MapR-DB.
And MapR-DB plugin for now leverages the same way of project push down as
HBase due to the `MapRDBBinaryTable` introducing.
Or did I miss something?
---
