GitHub user kkhatua opened a pull request:

    https://github.com/apache/drill/pull/987

    DRILL-5863: Sortable table incorrectly sorts fragments/time lexically

    The DataTables jQuery library sorts data based on the value of the element 
in a column.
    However, since Drill publishes sortable items like fragment IDs and time 
durations as non-numeric text, the sorting is incorrect. 
    This PR fixes the fragment and duration ordering based on their implicit 
numeric values (minor ID and millisecond representation, respectively).

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kkhatua/drill DRILL-5863

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/drill/pull/987.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #987
    
----
commit dee20aae602f86d14ddb832e7185499556c6a1e1
Author: Kunal Khatua <kkha...@maprtech.com>
Date:   2017-10-12T00:17:03Z

    DRILL-5863: Sortable table incorrectly sorts fragments/time lexically
    
    The DataTables jQuery library sorts data based on the value of the element 
in a column.
    However, since Drill publishes sortable items like fragment IDs and time 
durations as non-numeric text, the sorting is incorrect. 
    This PR fixes the fragment and duration ordering based on their implicit 
numeric values (minor ID and millisecond representation, respectively).

----


---

Reply via email to