Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/987#discussion_r144914422
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/OperatorWrapper.java
 ---
    @@ -76,12 +77,14 @@ public String getId() {
       public String getContent() {
         TableBuilder builder = new TableBuilder(OPERATOR_COLUMNS, 
OPERATOR_COLUMNS_TOOLTIP, true);
     
    +    Map<String, String> attributeMap = new HashMap<String, String>(); 
//Reusing for different fragments
         for (ImmutablePair<ImmutablePair<OperatorProfile, Integer>, String> ip 
: opsAndHosts) {
           int minor = ip.getLeft().getRight();
           OperatorProfile op = ip.getLeft().getLeft();
     
    +      attributeMap.put("data-order", String.valueOf(minor)); //Overwrite 
values from previous fragments
           String path = new 
OperatorPathBuilder().setMajor(major).setMinor(minor).setOperator(op).build();
    -      builder.appendCell(path);
    +      builder.appendCell(path, attributeMap);
    --- End diff --
    
    Does `appendCell` copy the map contents? If not, if it simply holds onto 
the map, then all cells hold the same map, which is probably not what you want.


---

Reply via email to