Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/970#discussion_r144924491
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/writer/TestParquetWriter.java
---
@@ -184,25 +183,26 @@ public void testAllScalarTypes() throws Exception {
try {
// read all of the types with the complex reader
- test(String.format("alter session set %s = true",
ExecConstants.PARQUET_NEW_RECORD_READER));
+ alterSession(ExecConstants.PARQUET_NEW_RECORD_READER, true);
--- End diff --
Good point. Here, I was not changing the semantics of the test; rather just
ensuring that the tests are deterministic in doing what they already did.
Presumably the test author knew which reader to use for which test. In fact,
the fact that the tests now pass indicates that the proper reader is used (or,
at least, the wrong reader is not used...)
---
