Github user ilooner commented on a diff in the pull request:

    https://github.com/apache/drill/pull/970#discussion_r145762743
  
    --- Diff: 
contrib/storage-hive/core/src/test/java/org/apache/drill/exec/hive/TestHiveStorage.java
 ---
    @@ -74,10 +73,8 @@ public void testNativeScanWhenNoColumnIsRead() throws 
Exception {
               .baselineValues(200l)
               .go();
         } finally {
    -      final OperatorFixture.TestOptionSet testOptionSet = new 
OperatorFixture.TestOptionSet();
    -      test(String.format("alter session set `%s` = %s",
    -          ExecConstants.HIVE_OPTIMIZE_SCAN_WITH_NATIVE_READERS,
    -          
Boolean.toString(testOptionSet.getDefault(ExecConstants.HIVE_OPTIMIZE_SCAN_WITH_NATIVE_READERS).bool_val)));
    +      test(String.format("alter session reset `%s`",
    --- End diff --
    
    Minor nitpick. The String.format is not necessary here. BaseTestQuery has a 
test method that does the String.format for you.


---

Reply via email to