Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/984#discussion_r145292776 --- Diff: exec/java-exec/src/test/java/org/apache/drill/TestAggNullable.java --- @@ -21,29 +21,25 @@ import org.apache.drill.categories.OperatorTest; import org.apache.drill.common.util.TestTools; +import org.apache.drill.test.BaseTestQuery; import org.junit.Test; import org.junit.experimental.categories.Category; @Category(OperatorTest.class) -public class TestAggNullable extends BaseTestQuery{ +public class TestAggNullable extends BaseTestQuery { static final org.slf4j.Logger logger = org.slf4j.LoggerFactory.getLogger(TestAggNullable.class); - static final String WORKING_PATH = TestTools.getWorkingPath(); - static final String TEST_RES_PATH = WORKING_PATH + "/src/test/resources"; - private static void enableAggr(boolean ha, boolean sa) throws Exception { - test(String.format("alter session set `planner.enable_hashagg` = %s", ha ? "true":"false")); - test(String.format("alter session set `planner.enable_streamagg` = %s", sa ? "true":"false")); + test("alter session set `planner.enable_hashagg` = %s", ha); + test("alter session set `planner.enable_streamagg` = %s", sa); --- End diff -- I was about to suggest using the functions created for this purpose. But, then I realized those changes are in a PR that has not yet been reviewed...
---