Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/984#discussion_r144943191
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/expr/CodeGenerator.java ---
    @@ -90,12 +89,11 @@
       private String generatedCode;
       private String generifiedCode;
     
    -  CodeGenerator(TemplateClassDefinition<T> definition, 
FunctionImplementationRegistry funcRegistry, OptionSet optionManager) {
    -    this(ClassGenerator.getDefaultMapping(), definition, funcRegistry, 
optionManager);
    +  CodeGenerator(TemplateClassDefinition<T> definition, OptionSet 
optionManager) {
    +    this(ClassGenerator.getDefaultMapping(), definition, optionManager);
    --- End diff --
    
    Good analysis. It was a real pain to lug the function registry around. 
Presumably the registry is used elsewhere in code gen; perhaps in the 
expression materializer.


---

Reply via email to